Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update llvm-kompile-compute-loc and llvm-kompile-compute-ordinal #1094

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

dwightguth
Copy link
Collaborator

These binaries were not quite feature-complete with their original intended purpose, probably primarily because at the time at which they were reimplemented, the past version of them was somewhat broken.

This PR adds the following features:

  1. Outputting the k location is the default in llvm-kompile-compute-loc
  2. If a k location does not exist, it falls back to the kore location rather than crashing.
  3. The output is formatted with both a filename and a line number.
  4. In llvm-kompile-compute-ordinal, you can specify a filename and it will search for the ordinal of a k rule on that line of that file in the input definition.

@dwightguth dwightguth requested review from Robertorosmaninho and removed request for Robertorosmaninho June 17, 2024 18:01
@rv-jenkins rv-jenkins changed the base branch from master to develop June 17, 2024 18:02
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall implementation LGTM, however, I believe we can improve it a bit! Thanks for this upgrade, Dwight!

tools/llvm-kompile-compute-loc/main.cpp Outdated Show resolved Hide resolved
tools/llvm-kompile-compute-loc/main.cpp Outdated Show resolved Hide resolved
@dwightguth dwightguth marked this pull request as ready for review June 18, 2024 17:57
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the comments!

@dwightguth dwightguth merged commit f419535 into develop Jun 18, 2024
10 checks passed
@dwightguth dwightguth deleted the compute-loc branch June 18, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants